Markus Staab comments

Results 1263 comments of


                                            Markus Staab

Support CallLike with variable method name

just now saw the feedback in https://github.com/phpstan/phpstan/issues/2920#issuecomment-2399602921 - will consider

Support CallLike with variable method name

the issue targeted with this PR was resolved in the meantime

False-positive: Method never returns XX so it can be removed from the return type.

I wonder how we want to decide for which union types we want this error beeing reported and for which not.

False-positive: Method never returns XX so it can be removed from the return type.

stumbled over the same problem today in a different context: signature enforced by interface vs. more precise type on the implementation end. the `MinPhpVersionInterface` interface resides in a different package...

False-positive: Method never returns XX so it can be removed from the return type.

> This interface is used on multiple Enums, some do return null as designed. > Those who do not are reported that the `null` should be removed. even if your...

Support `--skip-file` with `fnmatch` patterns

sorted the files, so hopefully we get consistent results across platforms.

Support `--skip-file` with `fnmatch` patterns

@TomasVotruba do you have a second? :)

False error: Constant ... overriding constant ... with different value ... should have the same value (non-ignorable false error on a valid code)

Issue bot will send a comment when its fixed. Until then you can stick to ondreys suggestion: > Feel free to revert to a last working version, or send a...

[Serializer] Add support for auto generated custom normalizers

> To my understanding isset() checks have always been (way) faster than array_key_exists(). Obviously there is the difference in null handling, but over the years I've seen quite a lot...

`ini_set('error_log'` sets filepath outside `open_basedir`

Could you PR a small reproducer of the problem as PHPT test?