Markus Staab
Markus Staab
I would put the code in question into a web-ui e.g. https://phpast.com/ or https://getrector.com/ast which generates a "clickable-ast". that way you get an overview how the code is represented in...
Just found https://github.com/phpstan/phpstan-src/pull/1828#issuecomment-1277121044 again, which tells me this PR might not be acceptable
I used $strict as bool, because other methods in Type also use it. Do you see a use-case where Trinary would come in handy?
> Please fix the conflict. resolved. build errors are unrelated and fixed separately in https://github.com/phpstan/phpstan-src/pull/4104
> @staabm I don't think we should use this knowledge to improve performance (it'd be negligible). I think we should use it to report "@dataProvider is deprecated on PHPUnit 11.x"...
Maybe it makes sense to add new common base-classes (simular to CallLike), so you can at least reduce the number of "instanceof checks" required. E.g. `LoopLike` as base for loop...
> I now would like to be able to trigger an error when the corresponding issue in the dependencies issue-tracker is fixed. Or when the PR in the dependencies VCS...
see e.g. [this cross-repo example](https://github.com/staabm/phpstan-todo-by/blob/da684ec1641e56b6dd67cd01207cdae9ca216d1e/tests-e2e/github/src/github-issues-and-prs.php#L5)
I think this was requested in the past and declined because 32bit is super rare