Markus Staab

icon indicating a website link https://staabm.github.io/ icon indicating an email [email protected]

icon location Germany icon location I am available for paid support of PHPStan and related static analysis tooling.

Results 1458 comments of Markus Staab

Index for loop inference should only work in lists

Good find. The bug was likely introduced in https://github.com/phpstan/phpstan-src/pull/4403 Do you like working on a fix?

Index for loop inference should only work in lists

If you see room for improvement feel free to send a PR. I will support you on the way as good as I can

Psalm crushes in normal mode but ok in debug

got a similar problem, but for "enum" > Uncaught InvalidArgumentException: Could not get class storage for infection\framework\enum\t in phar:///Users/staabm/workspace/infection/.tools/psalm/src/Psalm/Internal/Provider/ClassLikeStorageProvider.php:39

Stärkere csrf tokens

Hier ein explainer bzgl csrf https://cheatsheetseries.owasp.org/cheatsheets/Cross-Site_Request_Forgery_Prevention_Cheat_Sheet.html

PoC XML report rework

fwiw, I did a similar rework of the phpunit xml-report coverage generation report in https://github.com/sebastianbergmann/php-code-coverage/pull/1125 previously it was generating xml with XMLWriter, interleaved with some DOM retrieval. after this PR...

error formatter returns a invalid file path

the problem is that the file-path already is wrong , therefore the editor url does not matter at this point. I will try to reproduce

Prevent false positive on `method_exists()` and `function_exists()`

Maybe there should be a config switch to enable/disable this rule for function/method_exists?

Introduce all-methods-are-(im)pure

I did not look into all details of this PR, but maybe you can do something like ```php class X { public function returnsVoid(): void{} public function returnsInt(): int{} public...