phpstan-src icon indicating copy to clipboard operation
phpstan-src copied to clipboard

More precise sprintf() format-arg based return type

Open staabm opened this issue 1 year ago • 2 comments

extracted from https://github.com/phpstan/phpstan-src/pull/3168

closes https://github.com/phpstan/phpstan/issues/11248 closes https://github.com/phpstan/phpstan/issues/10493

the previous format-type based logic was too optimistic regarding types and false-positively created too precise types in some cases.

staabm avatar Jun 28 '24 07:06 staabm

I think the remaining error is a bug: https://github.com/phpstan/phpstan/issues/11249

staabm avatar Jun 28 '24 09:06 staabm

This pull request has been marked as ready for review.

phpstan-bot avatar Jun 28 '24 10:06 phpstan-bot

sorry for all these commits to make it finally build on php 7.2 without errors.

staabm avatar Jul 19 '24 07:07 staabm

Thank you!

ondrejmirtes avatar Jul 19 '24 11:07 ondrejmirtes