Markus Staab

Results 1468 comments of Markus Staab

> You don't appear on the issue bot yes, thats because the issue does not yet have a label like "bug" or "feature request". issue-bot does not look into unlabelled...

I had a look but cannot yet make sense of it

looks like this fix regresses https://github.com/phpstan/phpstan/issues/8372 which was fixed recently see https://github.com/phpstan/phpstan-src/actions/runs/18634779784#summary-53124523776

> Was it really fixed? hmm seems you are right. even on the latest dev-2.1.x it does not look fixed. maybe a issue-bot bug then. ``` ➜ phpstan-src git:(2.1.x) ✗...

I think this might be hard to detect. in this simple example, I think we could e.g. detect that there is a path thru the test which does not contain...

please have a look at the [issue-bot github action job summary](https://github.com/phpstan/phpstan-src/actions/runs/17018504744?pr=4246). it seems this PR also affects other issues. please add regression tests for those which are getting fixed

Welcome 🤗 Type related tests go usually into the https://github.com/phpstan/phpstan-src/tree/2.1.x/tests/PHPStan/Analyser/nsrt/ directory. Files located in this directory will automatically checked against using assertType().

just a gut feeling in case the 2 above comments regarding behaviour changes are not valid: another source of problems could be - `class ErrorType extends MixedType` - `class TemplateMixedType...