Markus Staab

Results 1468 comments of Markus Staab

a better version of this PR is implemented in https://github.com/phpstan/phpstan-src/pull/3881

sounds like you have an idea on how this should look like. is it just adding a new VirtualNodeType and invoking them on `$nodeCallback` - or do you have something...

noch nicht: https://github.com/FriendsOfREDAXO/rexstan/pull/387

hier sollten wir überlegen ob man dann den regulären phpstan job entfernt

should be rebased and adjusted after https://github.com/infection/infection/pull/2224, so we prevent creating 2 new timed-out mutants

> There's a recurrent pattern with exit codes where `exit(-1)` means `exit(255)`; so I'd consider the exit code thing especially carefully; the php-src manual explicitly states that `exit` takes 0-254...

> * Do not decrement comparison mb_strpos() with 0: and > * Do not decrement comparison of preg_match() with 0 as it can't return -1: was implemented with https://github.com/infection/infection/pull/2204

I think your examples are missing the generic types for your Collection parameter https://phpstan.org/r/6c537697-15ab-40aa-94eb-30bcef648304

I had a look into blackfire profiles and did not see any bottlenecks/resource hogs

`call_user_func_array()` can return `false` on error - I need to verify when this can happen