Markus Staab

sqlite-pdo instead of sqlite3

1

could you elaborate a bit, why you have chosen sqlite3 over sqlite-pdo?

output info about the registered testlistener

2

I think it would help debugging and configure the runner if it would output a message like `Running testsuite using clever-and-smart` before the actual test suite run so people see...

low prio: cleanup use statements

4

some classes define some crazy and un-used use statements. cleanup on next sweep. e.g. https://github.com/lstrojny/phpunit-clever-and-smart/blob/master/src/PHPUnit/Runner/CleverAndSmart/Storage/Sqlite3Storage.php#L4-L9

Verify results

1

Just for discussion... There is a visualisation phpunit plugin which shows the slowest tests. https://github.com/marmelab/phpunit-d3-report Maybe we can use it to verify our sorting for runtime related tests is accurate

Batch insert / update

3

Investigate if pushing each insert/update to a queue and and execute it in batches in a shutdown function would reduce IO and speedup things.

Version incorrectly reported

3

The version constant is not updated properly On cs2pr 1.3.0 calling `cs2pr --version` reports 1.1.0-dev https://github.com/staabm/annotate-pull-request-from-checkstyle/blob/53b28230d2aeda2fb22f5da4c16084ecd2378346/cs2pr#L19

when `cs2pr` completes and no errors/warnings have to be emitted, the screen stays empty. as a user I dont know whether everything worked well and nothing had to be reported...

Invoke composer validate after merge driver completed

1

The readme mentions > When a merge conflict occurs where the last property of an object is removed, accepting the removed version will result in invalid syntax due to a...

the color method is typed with a `array` parameter for `color`. https://github.com/bramus/ansi-php/blob/f581b2fd322177e5fabd67af240811838c1c8fbc/src/Traits/EscapeSequences/SGR.php#L47-L55 a lot of examples in the readme indicate that its finde to pass a single color. static analysis...