opendbc icon indicating copy to clipboard operation
opendbc copied to clipboard

Add Tesla Fuzzy Fingerprint

Open ssysm opened this issue 8 months ago • 7 comments

Allow Tesla to be fuzzy matched. Using the the TeM identifier for make id and model code after (25),. (Some random number)

ssysm avatar Mar 25 '25 23:03 ssysm

We need to make sure that this can restrict Teslas within a certain model year/capability range. For example, not HW2 (or others), and not Model S/X right now.

sshane avatar Mar 25 '25 23:03 sshane

Also see this comment: https://github.com/commaai/opendbc/issues/1917#issuecomment-2740315033

sshane avatar Mar 26 '25 02:03 sshane

Will check, thanks for the info

ssysm avatar Mar 26 '25 02:03 ssysm

We can potentially detect these missing APIs in the interface and set the dashcam flag if needed similar to Ford: https://github.com/commaai/opendbc/blob/1cc799801f03a45180de1e64193981b102aec5c4/opendbc/car/ford/interface.py#L70-L79

sshane avatar Mar 26 '25 02:03 sshane

Changed the firmware decode to a regex, should be able to extract the model code from the firmware. Added a VIN check to restrict only 2018+ cars Math.

As of HW2.5.. I'm not really sure, https://github.com/commaai/opendbc/issues/1917#issuecomment-2740315033. As far I'm seeing in from the route that lukas posted, the autoPark signal stayed at unavailable the whole trip in DI_State and DAS_Control message disappeared after few seconds. Maybe this can give a clue about if ACC is equipped on HW2.5? I really wished I had found more pattern but there's not a lot of information I can work with at this time.

ssysm avatar Mar 26 '25 07:03 ssysm

We should only ever use the VIN or the fingerprint to make this easier to reason about, not both

sshane avatar Mar 27 '25 06:03 sshane

If we want to restrict within a certain model year, the best way to do right now is to identify it with the VIN. One possible way is to identify using the VIN's 6th digit for model identification and 8th digit for possible AP HW variant?

ssysm avatar Mar 27 '25 15:03 ssysm

This PR has had no activity for 60 days. It will be automatically closed in 7 days if there is no activity.

github-actions[bot] avatar May 30 '25 02:05 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Jun 06 '25 02:06 github-actions[bot]