Shane Smiskol

Results 1136 comments of Shane Smiskol

- [x] https://github.com/commaai/openpilot/pull/34274 - [x] https://github.com/commaai/openpilot/pull/34275 - [ ] Forgetting doesn't hide forget button until you click it twice - [ ] Sometimes doesn't show connected to new connection (?)

@adeebshihadeh It still takes a few seconds to delete/create a connection (which times out some of our DBus calls), you noticed earlier that systemd is reloading something, and that still...

Summon goes into the autopark/summon state before ACC enables, but Autopark enables ACC right away so we currently can't know to forward it. Maybe we need to allow some delay...

There's a lot to verify here, can you split it out? Like switching the torque vs. pid tune setting and the min steer/engage speeds?

We've moved the car interfacing code to our [`opendbc`](https://github.com/commaai/opendbc) repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against [`opendbc`](https://github.com/commaai/opendbc) at your...

@jyoung8607 can you review? I pushed the route

We've moved the car interfacing code to our [`opendbc`](https://github.com/commaai/opendbc) repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against [`opendbc`](https://github.com/commaai/opendbc) at your...

It indeed should be showing for HDA1 cars, I think we forgot about this when merging https://github.com/commaai/openpilot/pull/26345. Can you get two routes: one with AEB disabled in the settings so...