openpilot icon indicating copy to clipboard operation
openpilot copied to clipboard

Hyundai: Stock longitudinal: Prevent disengagement on cancel button release

Open sunnyhaibin opened this issue 1 year ago • 3 comments

Description

This PR differs from https://github.com/commaai/openpilot/pull/34022, which only applies to Hyundai cars with a conditional parameter.

This PR is an interim fix, allowing all users to be unblocked from the disengagement bug until we develop a more comprehensive solution, tracking in https://github.com/commaai/openpilot/issues/34047.

Verification

  • Route: 2bbe12792a30f61f/0000048c--f94b4ede96

Resolves

  • https://github.com/commaai/openpilot/issues/34047
  • https://github.com/commaai/openpilot/issues/34057

sunnyhaibin avatar Nov 19 '24 16:11 sunnyhaibin

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Nov 29 '24 02:11 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Dec 01 '24 02:12 github-actions[bot]

@sshane can we please reopen this? This bug still exists in master and unresolved for Hyundai.

sunnyhaibin avatar Dec 08 '24 02:12 sunnyhaibin

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

github-actions[bot] avatar Dec 29 '24 02:12 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Jan 01 '25 02:01 github-actions[bot]

Fixed in https://github.com/commaai/openpilot/pull/34390

sshane avatar Jan 15 '25 05:01 sshane