FCA Giorgio: Alfa Romeo Stelvio

[jyoung8607]

Checklist

• [x] added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
• [ ] test route added to routes.py
• [ ] route with openpilot: TBD
• [ ] route with stock system: TBD
• [x] car harness used (if comma doesn't sell it, put N/A): VW_A

To-Do

• [ ] commaai/opendbc#1043
• [ ] commaai/panda#1980
• [ ] UDS/VIN fingerprinting
• [ ] Locate gearshift position signal
• [ ] Locate driver gas signal
• [ ] Locate cruise button signals
• [ ] Locate driver seatbelt signal
• [ ] Locate BSM signals
• [ ] Verify turn signal correctly processed (comfort vs latched, blink vs continuous)
• [ ] Plot out and test known HUD messaging (lane lines, etc)

Notes

The good: this platform uses the same Bosch MFK2 camera as earlier Volkswagen. The CAN messaging is entirely different, but we're able to use the VW_A harness unmodified straight from comma's store. So far, it seems to be getting down the road nicely, no apparent EPS lockout.

The not-so-good: the CAN topology seems to keep a lot of powertrain stuff away from the camera. On our first couple RE passes, I haven't been able to locate a CC button message or even a driver gas-press signal. We could maybe discuss NDOG-only operation if we truly can't find driver gas-press, but if we can't cancel-spam to sync ACC engagement state, that's going to be a problem for upstream. Now that we've proven drivability with no EPS lockout, I'll go a little more tryhard on those signals.

Wikipedia thinks the FCA Giorgio platform also covers Alfa Romeo Giulia, certain Maserati, and newer Jeep Grand Cherokee, but we won't be able to verify that without individual testing.

[github-actions[bot]]

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

• Convert your PR to a draft unless it's ready to review
• Read the contributing docs
• Before marking as "ready for review", ensure:
  • the goal is clearly stated in the description
  • all the tests are passing
  • the change is something we merge
  • include a route or your device' dongle ID if relevant

[AlexandreSato]

Confirmed gas pedal: fa46c09404cdf098/0000001e--2985aa24bc

jeep commander

[sshane]

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.