PySDM icon indicating copy to clipboard operation
PySDM copied to clipboard
verified publisher icon open-atmos

Paraview visualisation tool stand-alone; generation of docs landing site animation on CI + upload to tip release

Open olastrz opened this issue 1 year ago • 2 comments

olastrz avatar Jan 13 '25 12:01 olastrz

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.48%. Comparing base (e3a9e1a) to head (3156531). Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1499   +/-   ##
=======================================
  Coverage   85.48%   85.48%           
=======================================
  Files         392      392           
  Lines        9556     9556           
=======================================
  Hits         8169     8169           
  Misses       1387     1387

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Mar 20 '25 21:03 codecov[bot]

after logging in to the CI worker, it seems that no mp4 file is produced :(

runner@fv-az1280-241:~/work/PySDM/PySDM$ ls /tmp/pytest-of-runner/pytest-0/test_run_notebooks__home_runne1/output/
last_animation_frame.pdf         sd_attributes_num0000000348.vtu  sd_attributes_num0000000720.vtu  sd_products.pvd                sd_products_num0000000360.vts  sd_products_num0000000732.vts
sd_attributes.pvd                sd_attributes_num0000000360.vtu  sd_attributes_num0000000732.vtu  sd_products_num0000000000.vts  sd_products_num0000000372.vts  sd_products_num0000000744.vts
sd_attributes_num0000000000.vtu  sd_attributes_num0000000372.vtu  sd_attributes_num0000000744.vtu  sd_products_num0000000012.vts  sd_products_num0000000384.vts  sd_products_num0000000756.vts
sd_attributes_num0000000012.vtu  sd_attributes_num0000000384.vtu  sd_attributes_num0000000756.vtu  sd_products_num0000000024.vts  sd_products_num0000000396.vts  sd_products_num0000000768.vts
sd_attributes_num0000000024.vtu  sd_attributes_num0000000396.vtu  sd_attributes_num0000000768.vtu  sd_products_num0000000036.vts  sd_products_num0000000408.vts  sd_products_num0000000780.vts
sd_attributes_num0000000036.vtu  sd_attributes_num0000000408.vtu  sd_attributes_num0000000780.vtu  sd_products_num0000000048.vts  sd_products_num0000000420.vts  sd_products_num0000000792.vts
sd_attributes_num0000000048.vtu  sd_attributes_num0000000420.vtu  sd_attributes_num0000000792.vtu  sd_products_num0000000060.vts  sd_products_num0000000432.vts  sd_products_num0000000804.vts
sd_attributes_num0000000060.vtu  sd_attributes_num0000000432.vtu  sd_attributes_num0000000804.vtu  sd_products_num0000000072.vts  sd_products_num0000000444.vts  sd_products_num0000000816.vts
sd_attributes_num0000000072.vtu  sd_attributes_num0000000444.vtu  sd_attributes_num0000000816.vtu  sd_products_num0000000084.vts  sd_products_num0000000456.vts  sd_products_num0000000828.vts
sd_attributes_num0000000084.vtu  sd_attributes_num0000000456.vtu  sd_attributes_num0000000828.vtu  sd_products_num0000000096.vts  sd_products_num0000000468.vts  sd_products_num0000000840.vts
sd_attributes_num0000000096.vtu  sd_attributes_num0000000468.vtu  sd_attributes_num0000000840.vtu  sd_products_num0000000108.vts  sd_products_num0000000480.vts  sd_products_num0000000852.vts
sd_attributes_num0000000108.vtu  sd_attributes_num0000000480.vtu  sd_attributes_num0000000852.vtu  sd_products_num0000000120.vts  sd_products_num0000000492.vts  sd_products_num0000000864.vts
sd_attributes_num0000000120.vtu  sd_attributes_num0000000492.vtu  sd_attributes_num0000000864.vtu  sd_products_num0000000132.vts  sd_products_num0000000504.vts  sd_products_num0000000876.vts
sd_attributes_num0000000132.vtu  sd_attributes_num0000000504.vtu  sd_attributes_num0000000876.vtu  sd_products_num0000000144.vts  sd_products_num0000000516.vts  sd_products_num0000000888.vts
sd_attributes_num0000000144.vtu  sd_attributes_num0000000516.vtu  sd_attributes_num0000000888.vtu  sd_products_num0000000156.vts  sd_products_num0000000528.vts  sd_products_num0000000900.vts
sd_attributes_num0000000156.vtu  sd_attributes_num0000000528.vtu  sd_attributes_num0000000900.vtu  sd_products_num0000000168.vts  sd_products_num0000000540.vts  sd_products_num0000000912.vts
sd_attributes_num0000000168.vtu  sd_attributes_num0000000540.vtu  sd_attributes_num0000000912.vtu  sd_products_num0000000180.vts  sd_products_num0000000552.vts  sd_products_num0000000924.vts
sd_attributes_num0000000180.vtu  sd_attributes_num0000000552.vtu  sd_attributes_num0000000924.vtu  sd_products_num0000000192.vts  sd_products_num0000000564.vts  sd_products_num0000000936.vts
sd_attributes_num0000000192.vtu  sd_attributes_num0000000564.vtu  sd_attributes_num0000000936.vtu  sd_products_num0000000204.vts  sd_products_num0000000576.vts  sd_products_num0000000948.vts
sd_attributes_num0000000204.vtu  sd_attributes_num0000000576.vtu  sd_attributes_num0000000948.vtu  sd_products_num0000000216.vts  sd_products_num0000000588.vts  sd_products_num0000000960.vts
sd_attributes_num0000000216.vtu  sd_attributes_num0000000588.vtu  sd_attributes_num0000000960.vtu  sd_products_num0000000228.vts  sd_products_num0000000600.vts  sd_products_num0000000972.vts
sd_attributes_num0000000228.vtu  sd_attributes_num0000000600.vtu  sd_attributes_num0000000972.vtu  sd_products_num0000000240.vts  sd_products_num0000000612.vts  sd_products_num0000000984.vts
sd_attributes_num0000000240.vtu  sd_attributes_num0000000612.vtu  sd_attributes_num0000000984.vtu  sd_products_num0000000252.vts  sd_products_num0000000624.vts  sd_products_num0000000996.vts
sd_attributes_num0000000252.vtu  sd_attributes_num0000000624.vtu  sd_attributes_num0000000996.vtu  sd_products_num0000000264.vts  sd_products_num0000000636.vts  sd_products_num0000001008.vts
sd_attributes_num0000000264.vtu  sd_attributes_num0000000636.vtu  sd_attributes_num0000001008.vtu  sd_products_num0000000276.vts  sd_products_num0000000648.vts  sd_products_num0000001020.vts
sd_attributes_num0000000276.vtu  sd_attributes_num0000000648.vtu  sd_attributes_num0000001020.vtu  sd_products_num0000000288.vts  sd_products_num0000000660.vts  sd_products_num0000001032.vts
sd_attributes_num0000000288.vtu  sd_attributes_num0000000660.vtu  sd_attributes_num0000001032.vtu  sd_products_num0000000300.vts  sd_products_num0000000672.vts  sd_products_num0000001044.vts
sd_attributes_num0000000300.vtu  sd_attributes_num0000000672.vtu  sd_attributes_num0000001044.vtu  sd_products_num0000000312.vts  sd_products_num0000000684.vts  sd_products_num0000001056.vts
sd_attributes_num0000000312.vtu  sd_attributes_num0000000684.vtu  sd_attributes_num0000001056.vtu  sd_products_num0000000324.vts  sd_products_num0000000696.vts  sd_products_num0000001068.vts
sd_attributes_num0000000324.vtu  sd_attributes_num0000000696.vtu  sd_attributes_num0000001068.vtu  sd_products_num0000000336.vts  sd_products_num0000000708.vts  sd_products_num0000001080.vts
sd_attributes_num0000000336.vtu  sd_attributes_num0000000708.vtu  sd_attributes_num0000001080.vtu  sd_products_num0000000348.vts  sd_products_num0000000720.vts

slayoo avatar Apr 20 '25 21:04 slayoo

@olastrz, seems like mp4 files aren't supported in the Save Animation function (https://docs.paraview.org/en/v5.8/UsersGuide/savingResults.html#saving-animation), changing from .mp4 to .avi works to create the animation file!

emmacware avatar Apr 28 '25 10:04 emmacware

@emmacware we know, we used ogv but it is unluckily not supported as much as .mp4 :(

olastrz avatar Apr 28 '25 10:04 olastrz

Yeah, I think .avi is though!

emmacware avatar Apr 28 '25 11:04 emmacware

to sum up:

  • currently SaveAnimatuon is called with an .mp4 filename and it silently does nothing causing CI failure
  • let's try changing all occurences of .mp4 to .avi and hope it will fix it, and we can merge!

slayoo avatar Apr 28 '25 12:04 slayoo

browsers do not support AVI well.... let's generate .ogv and confert it to .mp4 on CI...

slayoo avatar Apr 29 '25 10:04 slayoo

closing & reopening to trigger CI

slayoo avatar May 01 '25 20:05 slayoo

@olastrz, ogv->mp4 conversion and all uploads seem to work OK!

The last remaining issue is that the animation is seemingly incompletely rendered, here's how the uploaded artifact looks like: image

Files:

  • https://github.com/open-atmos/PySDM/actions/runs/14782850972/artifacts/3047341420
  • https://github.com/open-atmos/PySDM/actions/runs/14782850972/artifacts/3047341370

slayoo avatar May 01 '25 23:05 slayoo

@olastrz, the animation now works on macos-13, but the output file is exactly the same as on Linux - white on gray without multiplicity scale: https://github.com/open-atmos/PySDM/actions/runs/14957602401

Could it be a Paraview version issue? Which version does it work correctly with?

slayoo avatar May 11 '25 18:05 slayoo

kudos @AgnieszkaZaba for solviong the mystery!!! (it was the version of pyevtk that PySDM uses for vtk file output, and which was pinned on CI to an older buggy release). Thanks @thearia0, for help in checking it on your system

slayoo avatar May 19 '25 20:05 slayoo