PyMPDATA icon indicating copy to clipboard operation
PyMPDATA copied to clipboard

fix: correct variable name

Open yoctoyotta1024 opened this issue 7 months ago • 2 comments

yoctoyotta1024 avatar Jul 17 '25 13:07 yoctoyotta1024

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.69%. Comparing base (a921acc) to head (44e51fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files          39       39           
  Lines        1697     1697           
=======================================
  Hits         1573     1573           
  Misses        124      124           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 21 '25 16:07 codecov[bot]

@Sfonxu (as we talked about it today), the key issue here is that without the change the code would not work, but the change is in a conditional branch that never gets executed on CI - which is a bug by itself. In #611, we suggest to split the example into two separate ones, so that the conditional expression goes away, and both "bin" and "bulk" code branches would be executed. Hence, suggest introducing this "split" in this PR - let's look at it on Thu.

thanks @yoctoyotta1024 for reporting it!

slayoo avatar Jul 22 '25 19:07 slayoo