Sylwester Arabas comments

Results 518 comments of


                                            Sylwester Arabas

first try at adding a Seeding dynamic

> Pylint is passing. ✅ But the tests that are passing locally are failing from a RuntimeWarning. ❌ Thank you, @claresinger ! In the workflow, we invoke pytest with the...

first try at adding a Seeding dynamic

> I think the problem is that `discretise_multiplicities` does not expect all values to be NaN, only some. But that excludes the case where there are no initial particles, only...

first try at adding a Seeding dynamic

codecov reports that the only single line missing test coverage is now (`particulator.py`): ```python + if n_null == 0: + raise ValueError( + "No available seeds to inject. Please provide...

first try at adding a Seeding dynamic

And here's a pattern we could use to actually check what type of exception is thrown in case of errors and if the exception message matches some expected string: https://stackoverflow.com/a/77005620/1487910

first try at adding a Seeding dynamic

working on the tests now...

first try at adding a Seeding dynamic

@claresinger, @jtbuch, we've made it! ![image](https://github.com/user-attachments/assets/438a4643-ecdb-4f12-90c4-e525fa4d880e)

New Spectral Sampling Following Optimal Transport Scheme of Matsushima eet al., 2023

being addressed here: https://github.com/open-atmos/PySDM/pull/1651

add the Long kernel

thank you @yoctoyotta1024 !

merge VapourDepositionOnIce into `Condensation` dynamic (refactoring the code to make it more open to other dynamics modifying the "predicted" quantities, e.g., latent heating due to homogeneous nucleation of vapour)

using "tendency" nomenclature/concept would make the code clearer as well, even if keeping with the current basic logic

merge VapourDepositionOnIce into `Condensation` dynamic (refactoring the code to make it more open to other dynamics modifying the "predicted" quantities, e.g., latent heating due to homogeneous nucleation of vapour)

plan: - [ ] explain in a docstring how tendencies are handled for thermodynamic vars (see also https://github.com/open-atmos/PySDM/discussions/1545) - [ ] add tests with asserts on mass and energy conservation...