Sylwester Arabas comments

Results 518 comments of


                                            Sylwester Arabas

rename water_vapour_m_x to predicted_water... in condensation solver where needed

@tluettm, trying to implement this change, I've noticed that the condensation code is structured in a way that it takes a *copy* of the "current" moisture/theta var, modifies this copy...

for testing purposes, equip the `Box` environment with `get_predicted()` logic to help in testing dynamics like deposition or nucleation without engaging the `Moist` environments

CC @tluettm

for testing purposes, equip the `Box` environment with `get_predicted()` logic to help in testing dynamics like deposition or nucleation without engaging the `Moist` environments

probably, a "MoistBox" environment would make numerous tests more readable

for testing purposes, equip the `Box` environment with `get_predicted()` logic to help in testing dynamics like deposition or nucleation without engaging the `Moist` environments

a draft of `MoistBox` class is now part of https://github.com/open-atmos/PySDM/pull/1389

for testing purposes, equip the `Box` environment with `get_predicted()` logic to help in testing dynamics like deposition or nucleation without engaging the `Moist` environments

and since #1389 was merged, closing here

make all dimensional analysis tests use `physics` submodules directly rather than through `Formulae` (to avoid using `@pytest.mark.skipif("numba.config.DISABLE_JIT")`)

For the record, one way of workarounding it, would be to access `physics` sybmodules (also) directly in unit tests, rather than through `Formulae`?

make all dimensional analysis tests use `physics` submodules directly rather than through `Formulae` (to avoid using `@pytest.mark.skipif("numba.config.DISABLE_JIT")`)

Actually, accessing physics directly in unit tests (as done, e.g., here: #1565) makes the dimensional analysis checks work regardless of JIT settings. This makes it not necessary to repeat `@pytest.mark.skipif("numba.config.DISABLE_JIT")`for...

Sylwester Arabas

rename water_vapour_m_x to predicted_water... in condensation solver where needed

for testing purposes, equip the `Box` environment with `get_predicted()` logic to help in testing dynamics like deposition or nucleation without engaging the `Moist` environments

for testing purposes, equip the `Box` environment with `get_predicted()` logic to help in testing dynamics like deposition or nucleation without engaging the `Moist` environments

for testing purposes, equip the `Box` environment with `get_predicted()` logic to help in testing dynamics like deposition or nucleation without engaging the `Moist` environments

for testing purposes, equip the `Box` environment with `get_predicted()` logic to help in testing dynamics like deposition or nucleation without engaging the `Moist` environments

make all dimensional analysis tests use `physics` submodules directly rather than through `Formulae` (to avoid using `@pytest.mark.skipif("numba.config.DISABLE_JIT")`)

make all dimensional analysis tests use `physics` submodules directly rather than through `Formulae` (to avoid using `@pytest.mark.skipif("numba.config.DISABLE_JIT")`)

raw=True flag for attribute saving in S&H example

acknowledge (in docstring) Howell 1949 F4, F5, F6 factors as equivalent (?) to Mason's drop growth law?

acknowledge (in docstring) Howell 1949 F4, F5, F6 factors as equivalent (?) to Mason's drop growth law?