Sylwester Arabas
Sylwester Arabas
closing as this is going to be part of #1568
In https://github.com/open-atmos/PySDM/pull/1367/commits/292d4fb4e388029bda17e8563d4ce2709343523d, there is a seeding/no-seeding plot layout depicting what happens also without seeding
@claresinger, thanks! I'd vote for placing this type of test into `smoke_tests` rather than `unit_tests` - it checks much more than just the seeding dynamic "unit" (and it takes much...
great that the push worked, thanks! I'll try to reduce code duplication in the smoke test now
BTW, adding a new folder in smoke tests requires also adding an entry here: https://github.com/open-atmos/PySDM/blob/55e0cce99bd582df5aeb5136289bd94289b687c6/.github/workflows/tests%2Bartifacts%2Bpypi.yml#L128
> Also, we could avoid copy-pasting code and run the hello_world notebook via the [notebook_vars](https://github.com/open-atmos/PySDM/blob/main/examples/PySDM_examples/utils/notebook_vars.py) fixture and assert on its variables... Looking close, I'd say we can better simplify the...
> > Also, we could avoid copy-pasting code and run the hello_world notebook via the [notebook_vars](https://github.com/open-atmos/PySDM/blob/main/examples/PySDM_examples/utils/notebook_vars.py) fixture and assert on its variables... > > Looking close, I'd say we can...
smoke test with asserts on the values in the hello-world notebook (sd_count & rain mixing ratio) added ✓
So, at this point we are missing: - [x] unit tests for sampling logic - [ ] saner handling of pool of candidates for sampling (currently all the vector is...
@claresinger > For the unit tests of sampling logic, what do we mean by that? Do you mean something like checking if the seeded particle sizes/other attributes do well reproduce...