Sylwester Arabas comments

Results 518 comments of


                                            Sylwester Arabas

bump pibind11

no longer an issue after migration to nanobind, thanks @Griger5!

new examples: R.R. Rogers 1975 (Atmosphere 13(4)) fig 1 (parcel model using SciPy+Pint, without PySDM)

thank you, @AgnieszkaZaba !

new example: Jouzel et al. 1975 Fig. 9 (same as Jouzel 1982 Fig. 2-1): isotopic relaxation timescale as a function of temperature and drop radii

this is actually Fig. 9 from [Jouzel et al. 1975](https://doi.org/10.1029/JC080i036p05015): ![Image](https://github.com/user-attachments/assets/23a4ac0b-78a6-47bd-b008-1acb61e847f7)

add a unit test for multi-cell SDM adaptivity covering the scenarion from adaptivity paper diagram (attached)

Likely place where it should go: https://github.com/open-atmos/PySDM/blob/main/tests/unit_tests/dynamics/collisions/test_sdm_multi_cell.py

add a unit test for multi-cell SDM adaptivity covering the scenarion from adaptivity paper diagram (attached)

starting point: https://github.com/open-atmos/PySDM/blob/main/tests/unit_tests/dynamics/collisions/test_sdm_single_cell.py (see gamma-mocking logic)

add a unit test for multi-cell SDM adaptivity covering the scenarion from adaptivity paper diagram (attached)

- [ ] turnb off the adaptivity and assert that deficit occurs

issues with the new 2D advection-duffusion example

.gif file upload works! The notebook does not work on Colab yet as it fails on first line with: ![image](https://github.com/user-attachments/assets/b0f3af04-4af6-454b-b07b-97d43d39ca65) This is due to lack of `pip install ...` commands...

issues with the new 2D advection-duffusion example

Just tested both on Colab and mybinder.org, and everything works! So, we're still missing two things: - [x] figures in the notebook are not displayed when viewed on GitHub -...

issues with the new 2D advection-duffusion example

kudos!

error output in notebookes is no longer detected by CI

https://github.com/open-atmos/PySDM/blob/89488a667547e367e4a9d4f3f97cf7a137a6f4cd/examples/PySDM_examples/Arabas_et_al_2025/copula_hello.ipynb This is fixed in the PR branch in a later commit, but even before the fix, CI was all green