Sylwester Arabas comments

Results 518 comments of


                                            Sylwester Arabas

add Matlab GHA workflow (with a struct-definition addition to the basic example)

@rwgk thanks! The above commit [e1a73a4](https://github.com/pybind/cmake_example/pull/164/commits/e1a73a4c9d8fe5706f6c8b6e6bd4acb2e017e586) is intended to try if it works. CI run requires maintainer approval.

add Matlab GHA workflow (with a struct-definition addition to the basic example)

Thanks @rwgk !

add Matlab GHA workflow (with a struct-definition addition to the basic example)

@rwgk We're trying to include this "trick" in the PyPartMC project where the original issue was discovered. Compilation is fine, instantiation of the objects work, and Python tests pass. In...

add Matlab GHA workflow (with a struct-definition addition to the basic example)

Yes, it did work with the `pybind11_type` trick. I'll try to reproduce it here...

add Matlab GHA workflow (with a struct-definition addition to the basic example)

debugging is tricky as I do not have access to Matlab beyond the Github Actions CI :) (the above commit checks if the use of `py::arg` could be the reason)

support for `nlohmann::ordered_json` in addition to `nlohmann::json`

@martinRenou @JohanMabille @NoahAmsel @SylvainCorlay ping :) having ability to use `ordered_json` would greatly help in our use case Thanks!

create a devops tests that checks if all example init.py files include the badges

also not the case here: https://github.com/open-atmos/PySDM/blob/main/examples/PySDM_examples/Spichtinger_et_al_2023/__init__.py

GPU backend is missing the `a_w_ice` and `record_freezing_temperatures` methods (tests present)

see #1496 (GPU-skipped test added there)

add a sanity check ensuring that Numba threading actually works

codecov marks is as uncovered because codecov is run with JIT compilation disabled, while the added logic is only tested with JIT compilation enable

bump pibind11

@emmacware just reported that the following happens with CMake 4.0.1: ``` CMake Error at gitmodules/pybind11/CMakeLists.txt:8 (cmake_minimum_required): Compatibility with CMake < 3.5 has been removed from CMake. Update the VERSION argument...