Johannes

Results 113 comments of Johannes

As Kris said above, can you move this to a dedicated class, e.g. ManifestGenerator? If there is nothing Symfony specific in there (which I figured from a cursory look), can...

For now, you can just use the tests as examples; there are plenty.

Maybe I'm missing something, but why do we need to duplicate so much code? :)

If you are not sure if it can be simplified more, just leave it as is, and I will take a look at it.

Could you add some more tests for bodies with different indentations, i.e. ``` php function foo() { // regular indentation // one more level indented } ```

I'd like to keep the downloading at least for Travis, but we could cache the downloaded contents locally. That way they would only be downloaded once (or when you manually...

That's a good point :) - I've just enabled Travis - not sure why it wasn't active. Requiring a fresh lock file just helps us ensure that we still support...

I'm wondering if we could make this BC by adding a second interface instead of changing the current interface?

I don't think that it is broken, but it has limitations if you depend on config instead of annotations for metadata. I'd suggest we deprecate it, and add another interface,...