Johannes

Results 113 comments of Johannes

I'm not sure we still need this bundle given the addition of autowiring and recent improvements to it. Could you tell us a bit more what features you still use...

If you use the symfony4 branch, this requirement should not be there anymore.

Why not add this in the code directly? ``` php function doSomething(FooInterface $service, $parameter, $string = "bar", array $array = array('abc', 'def')) {} ```

Do you use the controller as a non-service controller? Is the controller class inheriting from another class?

I guess we could add a simple flag to the config to disable grep. Not sure when I'll have time, but if it's a pressing issue, maybe you could add...

Could someone reproduce this on a fresh fork of the symfony-standard edition version 2.1?

Given the fragility of the cache warming system, I think the only viable solution moving forward is to convert the current cache warmer (HttpFoundation\ControllerCacheWarmer) class to a separate command which...

I think the best solution would be what I've written in a comment above, https://github.com/schmittjoh/JMSDiExtraBundle/issues/96#issuecomment-21028440

Ah, that's interesting. Then, we are talking about different errors here. Maybe we need to implement a similar strategy as the DoctrineBundle: https://github.com/doctrine/DoctrineBundle/blob/master/DoctrineBundle.php#L101

Could you check whether the workaround in #131 fixes these issues for you? If so, I'll merge that.