cg-library icon indicating copy to clipboard operation
cg-library copied to clipboard

Refactor to include ReflectinoClass to support better inheritance model

Open rande opened this issue 13 years ago • 5 comments

rande avatar Aug 20 '12 17:08 rande

This pull request fails (merged d7a8a042 into 9560e843).

travisbot avatar Aug 20 '12 17:08 travisbot

@schmittjoh this is a WIP, I will now work on the JMSAopBundle

If you have any comments, please go quick, I have a limited time window to contribute to this code!

rande avatar Oct 04 '12 22:10 rande

Maybe I'm missing something, but why do we need to duplicate so much code? :)

schmittjoh avatar Oct 04 '12 22:10 schmittjoh

If you are not sure if it can be simplified more, just leave it as is, and I will take a look at it.

schmittjoh avatar Oct 04 '12 22:10 schmittjoh

you are welcome to simplify this code ;) but without changing method's signatures this is going to be hard.

rande avatar Oct 04 '12 23:10 rande