assetic-bundle
assetic-bundle copied to clipboard
make it possible to generate cache manifest
We implemented a way to generate Cache Manifest Files in Assetic for the HTML5 Offline Mode
Offline Mode => http://diveintohtml5.org/offline.html
@kriswallsmith: we are not sure if you think this fits in here, but figured why not propose it and move it else where if you don't think it belongs here. As a result tests are currently missing. Think we also still have to check if the watch mode actually works.
I think this should be its own command.
Within AsseticBundle? Or a different Bundle entirely?
The reason why we put it here is that in theory the assets could get out of sync if its a two step process, aka if you change the assets in between the dump of the assets and generation of the manifest file.
@kriswallsmith: ping
ping
As Kris said above, can you move this to a dedicated class, e.g. ManifestGenerator? If there is nothing Symfony specific in there (which I figured from a cursory look), can you open a PR on assetic itself?
Also please add some tests, and a reference to the specification.
making it is own command as @kriswallsmith said above will lead to code duplication unless the entire DumpCommand is refactored. Just moving the new dumpManifest()
method to its own class as part of Assetic would however be fairly easy to do and is probably a sensible intermediate step.
could we keep this PR open for now if only for documenting a valid open feature request. thx.
+1