assetic-bundle icon indicating copy to clipboard operation
assetic-bundle copied to clipboard

make it possible to generate cache manifest

Open nicam opened this issue 12 years ago • 9 comments

We implemented a way to generate Cache Manifest Files in Assetic for the HTML5 Offline Mode

Offline Mode => http://diveintohtml5.org/offline.html

nicam avatar Oct 03 '11 11:10 nicam

@kriswallsmith: we are not sure if you think this fits in here, but figured why not propose it and move it else where if you don't think it belongs here. As a result tests are currently missing. Think we also still have to check if the watch mode actually works.

lsmith77 avatar Oct 03 '11 11:10 lsmith77

I think this should be its own command.

kriswallsmith avatar Oct 03 '11 16:10 kriswallsmith

Within AsseticBundle? Or a different Bundle entirely?

The reason why we put it here is that in theory the assets could get out of sync if its a two step process, aka if you change the assets in between the dump of the assets and generation of the manifest file.

lsmith77 avatar Oct 03 '11 17:10 lsmith77

@kriswallsmith: ping

lsmith77 avatar Nov 25 '11 08:11 lsmith77

ping

nicam avatar Jan 12 '12 13:01 nicam

As Kris said above, can you move this to a dedicated class, e.g. ManifestGenerator? If there is nothing Symfony specific in there (which I figured from a cursory look), can you open a PR on assetic itself?

Also please add some tests, and a reference to the specification.

schmittjoh avatar Mar 17 '12 23:03 schmittjoh

making it is own command as @kriswallsmith said above will lead to code duplication unless the entire DumpCommand is refactored. Just moving the new dumpManifest() method to its own class as part of Assetic would however be fairly easy to do and is probably a sensible intermediate step.

lsmith77 avatar Mar 17 '12 23:03 lsmith77

could we keep this PR open for now if only for documenting a valid open feature request. thx.

lsmith77 avatar May 06 '12 18:05 lsmith77

+1

estahn avatar Jul 01 '13 12:07 estahn