Johannes

Results 113 comments of Johannes

I need to think more about this, but it's the same in websphere. see http://publib.boulder.ibm.com/infocenter/wchelp/v6r0m0/topic/com.ibm.commerce.api.doc/com/ibm/commerce/payments/plugincontroller/PaymentsInterface.html#approveAndDeposit(com.ibm.commerce.edp.api.PaymentContext,%20java.lang.String,%20java.math.BigDecimal)

I only use PayPal at the moment.

This seems like an inconsistency to me. We probably need to adjust the state after the approveAndDeposit method to DEPOSITED, and also the state that is required by the reverseDeposit...

We have a related problem in #34

I think no-one is working on this atm, so you could write up a patch if you like.

I'm not convinced by this. If a route is restricted to another host and consequentially does not exist on the current host, then a 404 seems like the logical response...

Sounds good. Could you please add tests, and also check the CS of your patch?

I don't think that we can change this for now due to limitations of the GitHub API, but we can keep this open in case they extend their API.

Can we copy the exception to this bundle instead?