Johannes

Results 113 comments of Johannes

I was thinking about copying the code of the class here under a different class name, but since this is a new component, I think we could add a dependency...

That is true for Symfony >= 2.3, but not the older versions, which this bundle is still compatible with. So, we just need to add it so that Symfony <...

Instead of adding another find method, how about exposing the query builder instead?

It looks like composer cannot install your package: ``` Loading composer repositories with package information Installing dependencies Nothing to install or update Loading composer repositories with package information Installing dev...

Yeah, that's a good idea, and it already does that for a couple of composer errors. I'll see if we can add something for this error as well, not sure...

There was a bug when a package had no dependencies. Hopefully, that fixed your other reviews as well. I'll keep this open because better feedback in case of an error...

Yes, this seems necessary atm. Maybe I can change this from a compiler pass.

I think it should be possible. We have a slight inconsistency there at the moment, see also #11 and #58 for further reference.

This is expected actually, you can only add one `@PreAuthorize` annotation. Maybe you can elaborate your use case a bit because at the moment I don't see a need to...

I think we need to mark this as a documentation issue only or/and add an exception when `@PreAuthorize` is used in combination with other annotations. On one hand, this behavior...