ronso0
ronso0
Changes LGTM, though macOS CI is failing.
@poelzi Do you still maintain this branch? I wanted to do some testing on top of `main` so I resolved the conflicts and fixed the script. for anyone who want's...
(this still needs a 2nd approval : ) I can take a look at the UI in the next days.
> (this still needs a 2nd approval : ) > > I can take a look at the UI in the next days. Oh, when I wrote that I must...
Alright, LGTM*
Thank you for starting to map this controller! Usually new mappings go to the stable branch (2.3 in this case) unless they require features from the develoment branch (main). Is...
the pre-commit hooks are failing. please set up pre-commit locally and let the checks run to catch errors early. https://github.com/mixxxdj/mixxx/wiki/Coding%20Guidelines#pre-commit
> now pre-commit passed on my laptop it fails here because of unused variables https://github.com/mixxxdj/mixxx/runs/6063819583?check_suite_focus=true#step:6:113
Please don't resolve (collapse) review issues yourself, that is done by the reviewer(s). As a reviewer it's tedious to unfold again to check the reply / resolution.
Also: don't force-push once a review has been started. The comments are visible here in the PR view but in the file view they are detached = deleted. Just push...