mixxx icon indicating copy to clipboard operation
mixxx copied to clipboard

Update Changelog for 2.4

Open daschuer opened this issue 2 years ago • 8 comments

daschuer avatar Aug 06 '22 05:08 daschuer

please rebase on main so ci works again

Swiftb0y avatar Aug 06 '22 11:08 Swiftb0y

Done

daschuer avatar Aug 06 '22 21:08 daschuer

@Holzhaus There seems to be still an issue with the timestamp. Can you have a look?

daschuer avatar Aug 06 '22 22:08 daschuer

Is this based on latest main? It will always use the latest commit date of the most recent change of the changelog file.

I suppose you need to run pre-commit run --from-ref HEAD~1 --to-ref HEAD manually after modifying the changelog file. Because thr hook runs before committing, and during the commit the timestamp changes.

Sorry, but I see no other way to handle this. I think we need to think about removing the appstream metainfo from the repo and instead generate it on the fly during packaging. Then, we just use the current time which is not only easier but also more correct.

Holzhaus avatar Aug 07 '22 08:08 Holzhaus

It is still failing :-(

daschuer avatar Aug 08 '22 07:08 daschuer

So I cannot squash the commits, right?

daschuer avatar Aug 08 '22 07:08 daschuer

I have now changed the update_metainfo.py in a way that is picks the commit before the changes form the change log. That should work on CI and local in the same way, because the parent commit is the same in both cases.

It is also not to bad to use this date because that is the last change on the Mixxx source excluding CHANGELOG.md.

@Holzhaus What do you think?

daschuer avatar Aug 08 '22 22:08 daschuer

Hey pre-commit is green.

daschuer avatar Aug 08 '22 22:08 daschuer

Conflicts resolved! Merge?

daschuer avatar Aug 31 '22 20:08 daschuer

Changes LGTM, though macOS CI is failing.

ronso0 avatar Aug 31 '22 21:08 ronso0