ronso0

> just don't get sucked too far in :) Too late. Though I'm not refactoring but consolidating all `apply` code in, well, `slotApply`so that Cancel does.. cancel as it supposed...

While testing the changes I noticed another, additional bug in main: "Bypass EQ" ON is not taken into account after start -- until it's toggled Off and On again in...

"None" unloads the EQ effect (and hides the respective mixer controls). "Bypass" is more like a (temporary?) switch that keeps the EQ config. Idk, it's not a bug and not...

Okay, done: now all settings are applied and saved to config _only when hitting Apply_ (except Main Equalizer, as before). > IMO review should focus not focus on the code...

Please don't panic, instead look at the single commits first. You'll see most of what I did is moving all writing to config, setting COs and loading effects to `slotApply()`...

I notice I will probably not have time to respond to reviews and merge to main before I'm travelling. Marking as draft again, and finishing it when I'm back.

Yes, ready for review. Though, there'll be non-trivial conflicts with main, and I want to **avoid this being merged 'by accident'**, so "Finishing it" refers to me taking care of...

**All** EQ settings are applied instantly, that itself is a bug because the EQ page is not working as expected. Though, we can discuss if the shelf paramters should be...

Officially ready for review. My offer to port the changes to main still stands. Though, if I'm not available and someone needs to merge 2.3 into main in a hurry,...

Indeed, applying the slider values immediatly is probably desired as that is more practical. So the actual bug IMO is not that the parameters are applied immediatly but that they...