ronso0

Results 1331 comments of ronso0

> It zooms pretty fast, so maybe there could be call to increase the number of zoom levels. Which control did you map? (to what kind of input?) `waveform_zoom` is...

> I checked again earlier; the original works with a standard pot, the new one with a rotary encoder. Yes, the new "original one" (`waveform_zoom`) now works right away with...

> ``` > critical [Controller] DEBUG ASSERT: "!"pBehavior == nullptr, abort setValueFromMidi()"" in function void ControlDoublePrivate::setValueFromMidi(MidiOpCode, double) at ./src/control/control.cpp:347 > warning [Controller] Cannot get "[Channel1]" , "waveform_zoom" as Midi >...

Well, this branch is more than a year old so it has all the bugs of main back then. I've just rebased this, please test again.

Yup, that's right! I simplified the actual potmeter commit. I'd also pick https://github.com/mixxxdj/mixxx/commit/55418d00da24e01077e2bd8d7cedad561a672979 from https://github.com/mixxxdj/mixxx/pull/12373, wdyt?

And actually this can go to 2.5 now that it's just a backend change of the existing control. I think being able to map it to pots is an enhancement....

I fixed the build issue, but I also saw that the "zoom_set_default" buttons in Deere did not reset to the desired value. Couldn't reproduce again, so please do some thorough...

@LuccaPaiva Any chance you pick this up again and address the review comments?

Would probably be good to make the EQ / Stem dimming customizable. For some it's too dim, for some it's too strong.

@palaran If you refer to builds of #14951, you can get it the PR's CI summary. Details are here https://github.com/mixxxdj/mixxx/wiki/Testing#github-pull-requests Note that this PR is on top of the current...