ronso0
ronso0
> To fix the code style failures, download pre-commit.patch from the build artifacts, extract it and execute: > `git apply < pre-commit.patch` see https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking https://github.com/mixxxdj/mixxx/wiki/Contributing-Mappings
> It’s the first time I am doing this… Thanks for your work! you need to sign the contributor agreement so we can merge and publish your contribution https://docs.google.com/forms/d/e/1FAIpQLScC9QG327sjLL0eWftmfGUasxFFLxg6LCXJ2xHDYRzFIRqyiw/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ
there's no 2.3.1 milestone, yet, so I assigned this to 2.3.0, even tough it's unclear if this can be reviewed in time for the release.
@le3dmtl please have a look at the conversion in the brwoser: replies via email are a bit...oversized ; ) which makes it kinda hard to filter what the actual message...
I also very much recommend to read and learn about the `git` commands. First of all it's much quicker to work with than with the web GUI of github and...
Please rebase onto mixxx/2.3. Also, please install and run the pre-commit hooks to resolve the code style issues (see https://github.com/mixxxdj/mixxx/blob/main/CONTRIBUTING.md#git-workflow, 5th bullet point). The change set is small so you...
I think this is good enough to be mergd (if a second reviewer doesn't spot issues, of course). The preferences / startup UI integration is a bit more elaborate and...
Cool. I didn't do too many tests myself yet. With an arg config it shouldn't even matter if soundconfig.xml exists or not.
Sure, that makes sense. Tbh I consider this PR a temporary solution, so I'd rather implement this in #4862. There, only the basenames are visible in the preferences so we'd...