ronso0
ronso0
@fellock Any chance you pick this up again?
Great, thanks. fyi my intention was not push to, I was just going through some stale PRs to get an idea state is.
> The following tests FAILED: 288 - EngineSyncTest.EjectTrackSyncRemains (SEGFAULT) 363 - HotcueControlTest.SavedLoopUnloadTrackWhileActive (SEGFAULT) 530 - AdjustReplayGainTest.AdjustReplayGainUpdatesPregain (SEGFAULT) Errors while running CTest Who is able to review this?
Yeah, thanks for working on this!!
I'll test #1765 + this PR. Do you have any tricky cases in mind that deserve special testing?
Using your Shade implementation with 50% pitch range and a 160 BPM track: - rate_ultra > max up > BPM = 240 - touch rate slider > BPM jumps back...
> Currently it is just convenient that the rate slider doe not go out of sync. Yeah, but right now both faders have the same effect... > But how to...
A "Reset ultra pitch on track load" preferences option might also help.
> >Yeah, but right now both faders have the same effect... > That is also the case on the modeled turn table. nope. AFAIK (and what I tried to pin...
> instead of demanding features I'll finally bother with eclipse and delve into all that rate code. it's been a while since my key unlock PR :) feels like I...