Ryan Ly comments

Results 322 comments of


                                            Ryan Ly

Wrap data in set_data_io with a DataChunkIterator to support overriding hdf5 dataset backend configurations

Thank you @pauladkisson !

get_class to handle datetimes

This was raised as an issue by @tabedzki. 1. Attributes with `isodatetime`/`datetime` dtype cannot be built: ``` Traceback (most recent call last): File "/Users/rly/mambaforge/envs/berke2/lib/python3.12/site-packages/hdmf/build/objectmapper.py", line 1020, in __add_attributes attr_value, attr_dtype...

get_class to handle datetimes

@tabedzki Sorry for the delay. I have a few other pressing things on my plate right now. I will look at this again next week.

Append a Dataset of References

Minor suggestion to a test. Looks good otherwise.

Append a Dataset of References

I added a test that raises an unexpected error: ``` self = , name = @with_phil def __getitem__(self, name): """ Open an object in the file """ if isinstance(name, h5r.Reference):...

Append a Dataset of References

I see. Tricky indeed. You can't create an HDF5 reference to an object that isn't in the file yet, and rebuilding the whole hierarchy on each append is not ideal....

Allow override of constructor args and object attrs to return None

This causes a few errors in PyNWB that I will investigate.

Allow override of constructor args and object attrs to return None

> > This causes a few errors in PyNWB that I will investigate. > > Is this PR okay to review or should I wait for the PyNWB errors. Please...

Check DynamicTableRegion data is in bounds

#1293 should be merged before this

[Feature]: Remove or enchance the warning about ignoring cached name spaces

I could have sworn we had already made an issue on this but maybe we just discussed it. For hdmf-common and NWB core, I think we should raise the warning...