Ryan Ly

Results 297 comments of Ryan Ly

The PyNWB test is failing and needs to be investigated.

It seems that something is going wrong with differentiating the YAML: ```yaml shape: - null ``` from: ```yaml shape: null ``` No need to review yet. I will patch this...

The error in PyNWB is due to `dtype` and `shape` not being passed from parent type to subtype, so this PR requires #321, which solves that issue, to be merged...

TODO: Add support for auto-checking dims in auto-generated classes: https://github.com/NeurodataWithoutBorders/pynwb/issues/480

@mavaylon1 The place to move it would be https://github.com/hdmf-dev/hdmf/blob/dev/tests/unit/helpers/utils.py. However, moving that means also moving the container classes and mappers defined in this file `tests/unit/build_tests/mapper_tests/test_build.py`. We might then want to...

TODO: I will look into the coverage failure

I prefer "Any" instead of ":" to denote that any length is allowed.

@stephprince when you have time, can you review this?

@t-b This is actually for non-icephys data. Further investigation reveals that the validator is correctly not validating against the nwb.core namespace directly. Instead, what happens is that the file contains...