hdmf icon indicating copy to clipboard operation
hdmf copied to clipboard

Wrap data in set_data_io with a DataChunkIterator to support overriding hdf5 dataset backend configurations

Open pauladkisson opened this issue 1 year ago • 2 comments

Motivation

Fixes #1170

Checklist

  • [x] Did you update CHANGELOG.md with your changes?
  • [x] Does the PR clearly describe the problem and the solution?
  • [x] Have you reviewed our Contributing Guide?
  • [x] Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

pauladkisson avatar Aug 15 '24 18:08 pauladkisson

@oruebel, are there any problems with wrapping all data in a DataChunkIterator (numpy arrays, lists, tuples)? Should this fix be restricted to hdf5 datasets?

pauladkisson avatar Aug 15 '24 18:08 pauladkisson

are there any problems with wrapping all data in a DataChunkIterator (numpy arrays, lists, tuples)? Should this fix be restricted to hdf5 datasets?

Since the user has explicit control, I think this is fine. Also,, I believe it should work with numpy, lists, and tuples as well.

oruebel avatar Aug 15 '24 20:08 oruebel

@oruebel, can you enable tests for this PR?

pauladkisson avatar Sep 04 '24 16:09 pauladkisson

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.02%. Comparing base (874db31) to head (96ba306). Report is 22 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1172   +/-   ##
=======================================
  Coverage   89.01%   89.02%           
=======================================
  Files          45       45           
  Lines        9872     9879    +7     
  Branches     2810     2812    +2     
=======================================
+ Hits         8788     8795    +7     
  Misses        767      767           
  Partials      317      317           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 04 '24 17:09 codecov[bot]

@oruebel @rly CI tests pls?

pauladkisson avatar Sep 13 '24 17:09 pauladkisson

Looks like this is passing all the tests, can we merge?

pauladkisson avatar Sep 13 '24 20:09 pauladkisson

@rly @oruebel

pauladkisson avatar Sep 16 '24 20:09 pauladkisson

This looks good to me.

rly avatar Sep 16 '24 22:09 rly

Thank you @pauladkisson !

rly avatar Sep 16 '24 22:09 rly