hdmf
hdmf copied to clipboard
Wrap data in set_data_io with a DataChunkIterator to support overriding hdf5 dataset backend configurations
Motivation
Fixes #1170
Checklist
- [x] Did you update
CHANGELOG.mdwith your changes? - [x] Does the PR clearly describe the problem and the solution?
- [x] Have you reviewed our Contributing Guide?
- [x] Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?
@oruebel, are there any problems with wrapping all data in a DataChunkIterator (numpy arrays, lists, tuples)? Should this fix be restricted to hdf5 datasets?
are there any problems with wrapping all data in a DataChunkIterator (numpy arrays, lists, tuples)? Should this fix be restricted to hdf5 datasets?
Since the user has explicit control, I think this is fine. Also,, I believe it should work with numpy, lists, and tuples as well.
@oruebel, can you enable tests for this PR?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 89.02%. Comparing base (
874db31) to head (96ba306). Report is 22 commits behind head on dev.
Additional details and impacted files
@@ Coverage Diff @@
## dev #1172 +/- ##
=======================================
Coverage 89.01% 89.02%
=======================================
Files 45 45
Lines 9872 9879 +7
Branches 2810 2812 +2
=======================================
+ Hits 8788 8795 +7
Misses 767 767
Partials 317 317
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@oruebel @rly CI tests pls?
Looks like this is passing all the tests, can we merge?
@rly @oruebel
This looks good to me.
Thank you @pauladkisson !