Ryan Ly

Results 320 comments of Ryan Ly

FYI `dandi` is not a dependency of `pynwb`.

@samuelbray32 re: forward solution. Are new analysis NWB files created via the `export` function? You can generate new object IDs for each object in the nwbfile by calling `nwbfile.generate_new_id()` before...

@CBroz1 That approach is reasonable for the Frank Lab database, which should always be up-to-date with the latest version of Spyglass. Are we imagining that there might be multiple databases,...

I like this idea and think it would improve the experience for the average user who just wants to run code on their data like using a toolbox. Another disadvantage...

`get_data_shape` is used by the shape validator. If `maxshape` is present, then `get_data_shape` returns `maxshape`. Newly written data will have `maxshape` set to None for all axes. This will break...

`get_data_shape` is also used by the validator, so I worry that newly written datasets with a shape requirement that is non-None in some axis will be marked as invalid because...

The backend does not have direct access to the schema associated with a builder and is intentionally siloed from the schema. `write_builder`, `write_group`, `write_dataset`, etc. write the builder data as...

@mavaylon1 Yes, the validator should validate using actual shape not maxshape.

I think shape is validated before write in the docval of __init__ of the particular container class. If there is a custom container class, then the shape validation in docval...

Note: we need to consider this when working on implementing extendable datasets in HDMF again @mavaylon1