hdmf icon indicating copy to clipboard operation
hdmf copied to clipboard

Allow override of constructor args and object attrs to return None

Open rly opened this issue 1 year ago • 4 comments
trafficstars

Motivation

Fix #178

Checklist

  • [x] Did you update CHANGELOG.md with your changes?
  • [x] Does the PR clearly describe the problem and the solution?
  • [x] Have you reviewed our Contributing Guide?
  • [x] Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

rly avatar Aug 10 '24 08:08 rly

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.90%. Comparing base (316ec4b) to head (56e13b8).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1167      +/-   ##
==========================================
+ Coverage   88.88%   88.90%   +0.02%     
==========================================
  Files          45       45              
  Lines        9835     9835              
  Branches     2795     2795              
==========================================
+ Hits         8742     8744       +2     
+ Misses        776      775       -1     
+ Partials      317      316       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 10 '24 08:08 codecov[bot]

This causes a few errors in PyNWB that I will investigate.

rly avatar Aug 10 '24 22:08 rly

This causes a few errors in PyNWB that I will investigate.

Is this PR okay to review or should I wait for the PyNWB errors.

mavaylon1 avatar Aug 19 '24 04:08 mavaylon1

This causes a few errors in PyNWB that I will investigate.

Is this PR okay to review or should I wait for the PyNWB errors.

Please wait to merge. I haven't had time to look through these yet. If it does not make it in this upcoming release, that is OK.

rly avatar Aug 19 '24 17:08 rly