Patrick Ohly

Results 1004 comments of Patrick Ohly

/remove-lifecycle stale @BenTheElder: did I address your comments?

https://github.com/kubernetes/community/pull/8196 is also still open.

/remove-lifecycle stale I prefer to merge https://github.com/kubernetes/community/pull/8196 first.

Gentle ping... this is kind of urgent because of https://github.com/kubernetes/kubernetes/issues/127245.

> I think https://github.com/gotestyourself/gotestsum/pull/416 is the right fix for this. I got odd results when I tried it - see https://github.com/gotestyourself/gotestsum/pull/416#issuecomment-2355159877. > As a workaround, is it possible to run...

@dnephin: ping? Another alternative solution would be a command line option like `--pass-through-exit-code`: if true (not the default), the result of the `go test` invocation is used as the exit...

> Another alternative solution would be a command line option like --pass-through-exit-code: That won't actually help. In contrast to what I expected, the exit code is zero already. It's the...

Approvers could be the bottleneck. The more often they need to make themselves familiar with a KEP again the more work they have. It's also harder to see for graduation...

Also: - [x] https://github.com/kubernetes/kubernetes/issues/135177 - [x] https://github.com/kubernetes/kubernetes/pull/134935

> how the feedback should be presented, what should it include, etc. ? Let's collect feedback in a Slack thread on #wg-device-management. > https://github.com/kubernetes/kubernetes/issues/133757 is it sufficient? It will be...