kubernetes
tests: ensure that pre-submits get additional reviews
Blocking pre-submit jobs must be for stable, important features. Non-blocking pre-submit jobs should only be run automatically if they meet the criteria outlined in https://github.com/kubernetes/community/pull/8196.
To ensure that this is considered when defining pre-submit jobs, they need to be listed in config/tests/jobs/policy/presubmit-jobs.yaml. make update-config-fixtures re-generates that file to the expected state for inclusion in a PR.
/assign @aojea @BenTheElder
seems an interesting approach that may solve the existing problem, @BenTheElder is more familiar with all the edges here, let's hear his thoughts
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/test-infra/33958/pull-test-infra-unit-test/1868608463559462912
The test worked, my branch was out-dated and thus I didn't include an up-to-date generated file:
$ git diff
diff --git a/config/tests/jobs/presubmit-jobs.yaml b/config/tests/jobs/presubmit-jobs.yaml
index b7415779ba..197152ed12 100644
--- a/config/tests/jobs/presubmit-jobs.yaml
+++ b/config/tests/jobs/presubmit-jobs.yaml
@@ -25,7 +25,7 @@ run_if_changed:
run_if_changed: ^(go.mod|go.sum|vendor)
- name: pull-kubernetes-apidiff-client-go
optional: true
- run_if_changed: (^staging\/src\/k8s.io\/client-go)|(^staging\/src\/k8s.io\/code-generator\/examples)
+ run_if_changed: ((^staging\/src\/k8s.io\/client-go)|(^staging\/src\/k8s.io\/code-generator\/examples))/.*\.go
- name: pull-kubernetes-conformance-image-test
optional: true
run_if_changed: conformance
I suggest we remove or update jobs in separate PRs. I can then rebase this one and we merge it when we are happy with the current state.
Interesting...
$ make go-unit
hack/make-rules/go-test/unit.sh
+ umask 0022
+ mkdir -p /work/gopath/src/k8s.io/test-infra/_output
+ /work/gopath/src/k8s.io/test-infra/_bin/gotestsum --junitfile=/work/gopath/src/k8s.io/test-infra/_output/junit-unit.xml -- ./...
✓ config/prow/cluster/build/boskos-resources (cached)
✓ config/tests/jobs/policy (cached)
✓ config/tests/lint (cached)
✓ config/tests/mergelists (cached)
✓ config/tests/jobs (cached)
∅ def/configmap
...
DONE 6812 tests in 1.006s
$ echo $?
0
No failure!
But when I run go test manually, there is one:
$ go test ./...
...
--- FAIL: TestPresubmitsKubernetesDashboards (0.00s)
config_test.go:456: pull-kubernetes-e2e-gce-network-proxy-http-connect: should not be in presubmits-kubernetes-blocking because not actually merge-blocking for kubernetes/kubernetes
FAIL
FAIL k8s.io/test-infra/config/tests/testgrids 1.280s
...
ok k8s.io/test-infra/testgrid/pkg/configurator/prow (cached)
FAIL
Not good!
No failure!
My _bin/gotestsum might have been too old. I can't reproduce after rebuilding it.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
I think everything is addressed, just needs updating to the latest jobs (we've removed more from this list ...) /test all
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pohly Once this PR has been reviewed and has the lgtm label, please ask for approval from aojea. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
I prefer to merge https://github.com/kubernetes/community/pull/8196 first.