Patrick Ohly
Patrick Ohly
"main" != "master" ... => https://github.com/kubernetes/test-infra/pull/33585
/test pull-kubernetes-apidiff
/test pull-kubernetes-apidiff
/test pull-kubernetes-apidiff The false positives in the upstream apidiff might be fixed now.
Do we want `pull-kubernetes-apidiff` if there are any changes detected by apidiff, even if they are compatible (current behavior) or do we want it to pass in that case? I'm...
/test pull-kubernetes-e2e-gce "Services should implement NodePort and HealthCheckNodePort correctly when ExternalTrafficPolicy changes" ran into a timeout ("expected response containing : context deadline exceeded").
Let's also hold for a decision on https://github.com/kubernetes/kubernetes/pull/126387/files#r1810731571
> Let's also hold for a decision on https://github.com/kubernetes/kubernetes/pull/126387/files#r1810731571 This PR doesn't use "TODO logcheck:context", so it's fine. As Jordan had comments on https://github.com/kubernetes/kubernetes/pull/126387 about proper context support, I did...
@soltysh: care to take another look? I added fixup commits with my changes, but I could also apply them directly if you want to do a full pass over each...