Patrick Ohly

Results 1004 comments of Patrick Ohly

@BenTheElder I've tried to address both points in https://github.com/kubernetes/community/pull/8196#issuecomment-2503957800 with https://github.com/kubernetes/community/compare/a072efd375511540ba0e8aba4845f4d7d133f0ad..e113ccd92f78a8c26a3166799c6aa7fc9352565d > this approach is extremely error prone and has not gone well in the past for any attempt I've...

I did a major rewrite to cover presubmit jobs in general, not just those with `run_if_changed`. The "blocking presubmits must always run" is enforced by https://github.com/kubernetes/test-infra/pull/33958

/remove-lifecycle stale @BenTheElder: can we get back to this? Once we agree on the policy, we can proceed with enforcing it in https://github.com/kubernetes/test-infra/pull/33958.

Sorry, not anytime soon, I have too much on my plate already. It's also not particularly high priority because that test will soon not leak goroutines anymore, I just wanted...

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/test-infra/33958/pull-test-infra-unit-test/1868608463559462912 The test worked, my branch was out-dated and thus I didn't include an up-to-date generated file: ```diff $ git diff diff --git a/config/tests/jobs/presubmit-jobs.yaml b/config/tests/jobs/presubmit-jobs.yaml index b7415779ba..197152ed12 100644 --- a/config/tests/jobs/presubmit-jobs.yaml...

I suggest we remove or update jobs in separate PRs. I can then rebase this one and we merge it when we are happy with the current state.

Interesting... ```console $ make go-unit hack/make-rules/go-test/unit.sh + umask 0022 + mkdir -p /work/gopath/src/k8s.io/test-infra/_output + /work/gopath/src/k8s.io/test-infra/_bin/gotestsum --junitfile=/work/gopath/src/k8s.io/test-infra/_output/junit-unit.xml -- ./... ✓ config/prow/cluster/build/boskos-resources (cached) ✓ config/tests/jobs/policy (cached) ✓ config/tests/lint (cached) ✓ config/tests/mergelists (cached)...

> No failure! My `_bin/gotestsum` might have been too old. I can't reproduce after rebuilding it.