Patrick Ohly comments

Results 1004 comments of


                                            Patrick Ohly

bug(fakeclient): use fakeclient to create resource objects with GenerateName multiple times

This can be solved with custom reactors: https://github.com/kubernetes/kubernetes/blob/ec16c90aaf5d1f0606747c421c8680bb2b243d4e/pkg/controller/resourceclaim/controller_test.go#L580-L595 However, it would be nicer if fake client did this out-of-the-box. /kind feature

Enable go race detector for unit tests

I've implemented something like that for Kubernetes integration tests: https://github.com/kubernetes/kubernetes/pull/116980/commits/f2a237a8039e3a96eca969e526dda15e23844048

Enable go race detector for unit tests

No idea whether that is even remotely applicable to how test-infra runs unit tests...

panic when converting "go test -bench" output

Running with `--format standard-quiet` on the result file with output was a bit more informative: ``` *** Test killed with quit: ran too long (11m0s). exit status 2 === Failed...

panic when converting "go test -bench" output

I'm also seeing incorrect "failed" results for benchmarks which completed fine. Could be a bigger issue caused by the difference between unit tests and benchmarks...

panic when converting "go test -bench" output

> That's been a safeguard to prevent hiding failed test output due to previous test2json bugs. Is it possible to disable this safeguard? In Kubernetes, I recently changed how we...

panic when converting "go test -bench" output

Summarizing benchmarks worked with Go 1.19: ```console $ PATH=/nvme/gopath/go-1.19/bin:$PATH gotestsum --jsonfile /tmp/raw.json -- -bench=BenchmarkDiscardLogInfoOneArg ./benchmark && cat /tmp/raw.json ∅ benchmark (1.193s) DONE 0 tests in 1.478s {"Time":"2024-09-11T12:02:34.000797216+02:00","Action":"output","Package":"github.com/go-logr/logr/benchmark","Output":"goos: linux\n"} {"Time":"2024-09-11T12:02:34.000966654+02:00","Action":"output","Package":"github.com/go-logr/logr/benchmark","Output":"goarch: amd64\n"}...