Patrick Ohly
Patrick Ohly
> if we write to journald socket directly This could be useful, in particular when it ensures that multi-line log entries are treated as one entry. I'm a bit worried...
Suppose we don't use that protocol. How does systemd capture the stderr output from a process, i.e. what are the message boundaries in that case?
Then we shouldn't remove the klog header while using stderr because the message boundaries could get lost.
For option 1 I am still worried about handling line breaks - or rather, not handling them. Option 2 sounds better to me. Some small changes in klog may still...
Correct.
Resolved via https://github.com/kubernetes/kubernetes/pull/132033 /close
I'm trying a different workflow here and will intentionally include merge commits which bring in other pending PRs, like https://github.com/kubernetes/kubernetes/pull/127709. That allows me to use `git rebase --update-refs --rebase-merges --keep-root`...
I'm glad you like it :smile: A while back [I gave up on adding the script](https://github.com/kubernetes/kubernetes/pull/122971#issuecomment-1969291817) before trying again later.
/wg structured-logging