Patrick Ohly
Patrick Ohly
/remove-lifecycle stale /triage accepted /priority backlog
/close DRA in 1.31 will not have a resource handle anymore.
I tried copying. It almost works: ``` pflag.CommandLine.VisitAll(func(f *flag.Flag) { goflag.CommandLine.Var(f.Value, f.Name, f.Usage) }) goflag.Parse() ``` There's just one nuisance that makes this not a full solution: because https://cs.opensource.google/go/go/+/refs/tags/go1.17.1:src/flag/flag.go;l=467-504;drc=refs%2Ftags%2Fgo1.17.1 inspects...
I tried that idea and it works fine.
Is https://github.com/google/go-cmp perhaps a viable replacement for https://github.com/pmezard/go-difflib?
`go-cmp` might be overkill. A simple diff implementation for two sequences of a comparable type like strings in https://github.com/stretchr/testify/blob/b074924938f86d417f1c9a845c7e8b0784d7f937/assert/assertions.go#L1883-L1891 isn't hard to write - I'll have a look.
/assign @dims For approval. A new release for Kubernetes 1.31 also makes sense.
Hmm, we want a few more things for a new release, like https://github.com/kubernetes/klog/pull/404
/retest Does that work for GitHub actions? The linter wasn't happy, for some reason.
Linter failures fixed in main.