Patrick Ohly
Patrick Ohly
> for me, a fix for this bug may not be backward compatible. That's the key problem then: we cannot break existing users unless it is a clear bug fix...
According to this, `-stderrthreshold` only applies when writing to files and stderr ("Log events at or above this severity are logged to standard error *as well as* to files." -...
What you want is: ``` -stderrthreshold=ERROR Only log events at or above this severity are logged to standard error, regardless of the settings for -logtostderr and -alsologtostderr-alsologtostderr. ``` That is...
/remove-lifecycle rotten Waiting for slog in Go 1.21.
We could do this now, but I'd like to hear from @tallclair first whether this feature is really needed and going to be used.
So your proposal is that `lockAndFlushAll` shouldn't hold the lock while flushing, right? That seems reasonable to me, one just has to be careful about still holding the lock while...
> I suggest acquiring a lock when calling file.Flush() (to write the klog buffer into the kernel buffer), as not doing so may lead to exceptional issues. Indeed, `syncBuffer` (the...
/remove-lifecycle stale /lgtm /assign @dims For approval.
/close Will become part of a future KEP updated after prototyping it in https://github.com/kubernetes-sigs/wg-device-management.
/close Will become part of a future KEP updated after prototyping it in https://github.com/kubernetes-sigs/wg-device-management.