Patrick Ohly
Patrick Ohly
Weird. How can this PR break `TestFrameworkHandler_IterateOverWaitingPods/pods_with_same_profile_are_waiting_on_permit_stage`? https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/124595/pull-kubernetes-unit/1804178145381715968 Let's retest, just to see whether it is consistent. /retest
> How can this PR break `TestFrameworkHandler_IterateOverWaitingPods/pods_with_same_profile_are_waiting_on_permit_stage`? > > https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/124595/pull-kubernetes-unit/1804178145381715968 Looks like a flake, it also occurs in periodic jobs from time to time. I filed a bug: https://github.com/kubernetes/kubernetes/issues/125653
/retest Lots of unrelated test flakes...
It's not wrong to wait for more caches to be populated, but it's not really required to do that for PodSchedulingContext and ResourceClaimTemplate, is it? It will see the objects...
> It's not a big problem, but it's better to avoid it if we can. So it's better to wait for the cache to be populated. Agreed. > the test...
/assign @yujuhong For approval.
Are there other opportunities like this "nearby" (same plugin or in the scheduler)? This is a good change, but it's a bit small by itself.
@liyuerich: can you take a look at the remaining issues in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/120301/pull-kubernetes-e2e-kind/1770781549856296960 and https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/120301/pull-kubernetes-verify-lint/1770781557804503040?