Patrick Ohly
Patrick Ohly
verify: test-code: ``` Errors: test/e2e/storage/testsuites/volume_expand.go The above files need to use framework.ExpectNoError(err) instead of Expect(err).NotTo(HaveOccurred()) or gomega.Expect(err).NotTo(gomega.HaveOccurred()) ``` This indeed should be changed. `framework.ExpectNoError` is the only helper function that...
I know what this is for based on prior discussion on Slack, but I agree with @kannon92: this needs to be documented in the commit message and the PR description....
The plugin depends on APIs that are only available in k/k (`pkg/scheduler/framework`), therefore it cannot be moved to staging - perhaps it could, but any consumer then would still depend...
> I am assuming that is the way to test before getting merged Yes.
/sig scheduling
Also to be covered by unit testing: at the start of a pod scheduling attempt the `PodInfo.UnschedulablePlugins` set must be empty.
/remove-lifecycle stale /lifecycle frozen
The problem is that in many cases, we get the underlying type from static code analysis: https://github.com/ashanbrown/forbidigo/blob/1396000fa337b0f684b38a5206b36964d9573b39/forbidigo/forbidigo.go#L273-L285 I'm not sure whether it is possible to detect that the type was...
/hold The intent is that adding tests with only a `FeatureGate` label is sufficient. Before we allow such tests, we have to do some preparations - see checklist in description.