Patrick Ohly
Patrick Ohly
/close Will become part of a future KEP updated after prototyping it in https://github.com/kubernetes-sigs/wg-device-management.
/close In favor of https://github.com/kubernetes/enhancements/pull/4667.
/close Will become part of a future KEP updated after prototyping it in https://github.com/kubernetes-sigs/wg-device-management.
/close Will become part of a future KEP updated after prototyping it in https://github.com/kubernetes-sigs/wg-device-management.
That looks promising. I think it can satisfy all cases that I had in mind for this issue, so we can (almost) close it. The output could be a bit...
It's not just the matchers: the `Expected : {s: "foo"}` would also be more informative when it included the `Error()` result. I'm thinking of this case: ``` package test import...
Note that `gomega.Eventually` now prints the error string twice, once before the `format.Object()` result and once inside it: https://github.com/kubernetes/kubernetes/pull/116539/files#diff-89fa7733f32f68c3149970d6cc759c4bbb2e2e849629cca3b4d352f2ac59ee3a ``` [FAILED] Timed out after . The function passed to Eventually...
That looks better, please cut a release.
Why wait for 1.20? The format changes are compatible with the rules for older Go, i.e. one can reformat the comments with "go fmt" from Go 1.19 and they will...
I would update all comments and move gofmt checking to 1.19 in a single PR. Then once that PR is merged, the updated formatting requirements are met and enforced.