Patrick Ohly
Patrick Ohly
There are some more fixes that I want to include here: - [x] https://github.com/kubernetes/kubernetes/blob/781da7595167f872662db3bb62290d1b0522f666/test/utils/ktesting/assert.go#L110-L119 should use `tCtx.ExpectNoError` - [x] https://github.com/kubernetes/kubernetes/blob/781da7595167f872662db3bb62290d1b0522f666/test/utils/ktesting/assert.go#L142 misses some quotation marks and should explain that the message...
Currently the script can be run manually. The next step will be an optional, non-blocking `pull-kubernetes-apidiff` Prow job which invokes the script. We could also add some "run if changed"...
/sig testing
> Is this going to be useful? I am currently trying to make client-go support contextual logging. This is only possible via API changes (or rather, extensions). In that context...
There obviously wasn't much interest in having this in-tree. Let's close. /close
/reopen /assign @aojea
@aojea: as you were interested in using this, perhaps you can try it out? I just pushed an update that works with workspace mode. A simple test is: ```patch diff...
/retest
Let's merge it. /hold cancel
@moshe010: do you have time to work on this?