Petrik de Heus

Results 175 comments of Petrik de Heus

We could merge the other repos while keeping all the history. I had some success with the steps described here (https://thoughts.t37.net/merging-2-different-git-repositories-without-losing-your-history-de7a06bba804): ```cd /tmp git clone [email protected]:rspec/rspec-core.git git clone [email protected]:rspec/rspec-expectations.git cd...

If we are going to keep these for a while, should the autoload logic be copied to rackup instead? If a new version of Rack is released, the `Rack::Server` and...

@joaovictor-local This should be fixed on the stable-7-1 branch. See https://github.com/rails/rails/issues/52127 and https://github.com/rails/rails/pull/52093. @rafaelfranca could we get a 7.1.3.5 release to fix this in an offical release?

What about making @georgeclaghorn's monkey patches a commented-out initializer? Just like the Content Security Policy: https://github.com/rails/rails/blob/5647a9c1ced68d20338552d47a3b755e10a271c4/railties/lib/rails/generators/rails/app/templates/config/initializers/content_security_policy.rb.tt

Hey @jacobherrington, any idea why it fails with Tailwind?

@neanias Is "See X for more" also a bit problematic for visually impaired readers?

If you call `user.avatar.variant(:thumb)` a variant image is created (and stored on S3 if you are using S3). Whether or not you track variants does not matter, a file is...

Instead of having a config setting that requires a booted application, it would probably be better to have a clear API on CodeStatistics: ```ruby CodeStatistics.add_directory("My Directory", "path/to/dir") ```

I've changed the PR to use `CodeStatistics.add_directory` instead of `config.code_statistics.directories`.