Nicolas Grekas

Results 803 comments of Nicolas Grekas

> I'm working on a CiviCRM extension where on special classes @required on protected properties is a validation hint. > When I try to use autowiring for those classes it...

This is already tested by the added code paths to me. More tests would look like testing a getter to me :)

> I would also add a test, with a data provider alright, updated > Could we also plug this with #[WithHttpStatus] attribute ? Already handled, that's what the changes on...

> why the ClockSensitiveTrait::mockTime returns a PSR ClockInterface, instead of a Symfony ClockInterface No specific reason I can think of... > In the same idea, I'm not sure to clearly...

@ruudk please advise what you'd like to do with this PR. "Draft status" is blurry for OSS maintainers.

Another idea: since xdebug is sensitive to `$_GET` also, what would happen if we set those settings in the query string? Can this make xdebug ignore the cookie? Can you...

Thanks @derickr Let's update this PR by anticipating the new option?

LazyGhostTrait cannot break the contract of PropertyAccessorInterface because it is not bound by the contract. The issue is either in PropertyAccessor being too confident in having a __get meaning the...