Nicolas Grekas

Results 807 comments of Nicolas Grekas

`extra.symfony.require` applies only to packages that are listed in the `replace` section of `symfony/symfony`. `symfony/phpunit-bridge` is not one of them, neither is e.g `symfony/monolog-bundle`.

> [symfony/ux#1347 (files)](https://github.com/symfony/ux/pull/1347/files#diff-6487ef7c39e106956904930b49958df26d90de6e025cd0c69a1a9a84e31ed064) (the entire class could be replaced with a ServiceLocator) that's quite common needless overhead - we already simplified many components by using a container this PR is...

To make this full "IoC", one can type hint `ServiceProviderInteface&Traversable`, isn't it? Then LGTM.

let's do this on 6.4 as a bugfix

looks like a rebase is missing :)

Changing the type of thrown exceptions is not a bug fix so that's for 7.1 to me.

Thanks for proposing and for submitting! I'm wondering if we couldn't get rid of the interface and rename the proposed argument to e.g. `AutowireInline`? To remove the interface, we could...

I don't know, please follow up on an open issue or a PR :)